[rekonq] Re: Review Request: Optimize rekonq protocol handling

[Pierre Rossi]

Is there a good reason for this "fragmentation" in the coding style ?
I didn't realize until now that rekonq had a different coding style
regarding curly braces and often wondered why this stuff was "wrong" all
over the place...

The rationale is that the coding style in Qt and KDE is quite well known and
established for what I believe could be rekonq's developer target audience,
and it's documented and easy to find to, e.g. here:
http://techbase.kde.org/Policies/Kdelibs_Coding_Style

Well, as it is now, it's pretty hard to change without ruining the history,
or at least we'd need to re-write it with git filter-branch and the likes,
which could turn out to be a pain.

I guess I'll just have to fixup my curly braces from now on... ;)


On Mon, Oct 18, 2010 at 15:26, Jon Ander Peñalba <jonan88 at gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100062/
>
> On October 18th, 2010, 12:09 p.m., *Benjamin Poulain* wrote:
>
>   src/protocolhandler.cpp<http://git.reviewboard.kde.org/r/100062/diff/1/?file=931#file931line178> (Diff
> revision 1)
>
> bool ProtocolHandler::preHandling(const QNetworkRequest &request, QWebFrame *frame)
>
>    155
>
>     if(KProtocolInfo::isKnownProtocol(_url))
>
>   156
>
>     {
>
>   KDE's coding convention, the bracket should be on the same line as the if().
>
>  rekonq doesn't use exactly the same convention as KDE.
> http://gitweb.kde.org/rekonq.git/blob/HEAD:/scripts/codingstyle.sh
>
>
--
Pierre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101020/43ea8b3a/attachment.htm