[rekonq] Re: Review Request: Optimize rekonq protocol handling

[Jon Ander Peñalba]

> On 2010-10-18 12:09:19, Benjamin Poulain wrote:
> > src/protocolhandler.cpp, lines 178-179
> > <http://git.reviewboard.kde.org/r/100062/diff/1/?file=931#file931line178>
> >
> >     KDE's coding convention, the bracket should be on the same line as the if().

rekonq doesn't use exactly the same convention as KDE.

http://gitweb.kde.org/rekonq.git/blob/HEAD:/scripts/codingstyle.sh


- Jon Ander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100062/#review116
-----------------------------------------------------------


On 2010-10-14 18:09:59, Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100062/
> -----------------------------------------------------------
> 
> (Updated 2010-10-14 18:09:59)
> 
> 
> Review request for rekonq and Andrea Diamantini.
> 
> 
> Summary
> -------
> 
> This patch makes rekonq handle all possible protocols that KDE can handle, huge protocol optimization imo
> 
> 
> Diffs
> -----
> 
>   src/protocolhandler.cpp be23684 
> 
> Diff: http://git.reviewboard.kde.org/r/100062/diff
> 
> 
> Testing
> -------
> 
> Works perfectly on Kubuntu 10.10, tested with magnet/apt/ftp/mailto links
> 
> 
> Thanks,
> 
> Rohan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/rekonq/attachments/20101018/f495920b/attachment.htm