Is there a good reason for this "fragmentation" in the coding style ?<br>I didn't realize until now that rekonq had a different coding style regarding curly braces and often wondered why this stuff was "wrong" all over the place...<br>
<br>The rationale is that the coding style in Qt and KDE is quite well known and established for what I believe could be rekonq's developer target audience, and it's documented and easy to find to, e.g. here:<br><a href="http://techbase.kde.org/Policies/Kdelibs_Coding_Style">http://techbase.kde.org/Policies/Kdelibs_Coding_Style</a><br>
<br>Well, as it is now, it's pretty hard to change without ruining the history, or at least we'd need to re-write it with git filter-branch and the likes, which could turn out to be a pain. <br><br>I guess I'll just have to fixup my curly braces from now on... ;)<br>
<br><br><div class="gmail_quote">On Mon, Oct 18, 2010 at 15:26, Jon Ander Peņalba <span dir="ltr"><<a href="mailto:jonan88@gmail.com">jonan88@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>
<div style="font-family: Verdana,Arial,Helvetica,Sans-Serif;"><div class="im">
<table style="border: 1px solid rgb(201, 195, 153);" bgcolor="#f9f3c9" cellpadding="8" width="100%">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100062/" target="_blank">http://git.reviewboard.kde.org/r/100062/</a>
</td>
</tr>
</tbody></table>
<br>
</div><div class="im"><blockquote style="margin-left: 1em; border-left: 2px solid rgb(208, 208, 208); padding-left: 10px;">
<p style="margin-top: 0pt;">On October 18th, 2010, 12:09 p.m., <b>Benjamin Poulain</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid rgb(208, 208, 208); padding-left: 10px;">
<table style="border: 1px solid rgb(192, 192, 192); border-collapse: collapse;" bgcolor="white" border="0" width="100%">
<thead>
<tr>
<th colspan="4" style="border-bottom: 1px solid rgb(192, 192, 192); font-size: 9pt; padding: 4px 8px; text-align: left;" bgcolor="#f0f0f0">
<a href="http://git.reviewboard.kde.org/r/100062/diff/1/?file=931#file931line178" style="color: black; font-weight: bold; text-decoration: underline;" target="_blank">src/protocolhandler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: rgb(228, 217, 203); padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;">bool ProtocolHandler::preHandling(const QNetworkRequest &request, QWebFrame *frame)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th style="border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#b1ebb0"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"></pre></td>
<th style="border-left: 1px solid rgb(192, 192, 192); border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#b1ebb0"><font size="2">155</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"> <span>if</span><span>(</span><span>KProtocolInfo</span><span>::</span><span>isKnownProtocol</span><span>(</span><span>_url</span><span>))</span></pre>
</td>
</tr>
<tr>
<th style="border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#b1ebb0"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"></pre></td>
<th style="border-left: 1px solid rgb(192, 192, 192); border-right: 1px solid rgb(192, 192, 192);" align="right" bgcolor="#b1ebb0"><font size="2">156</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0pt;"> <span>{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; word-wrap: break-word;">KDE's coding convention, the bracket should be on the same line as the if().</pre>
</blockquote>
</blockquote>
</div><pre style="margin-left: 1em; white-space: pre-wrap; word-wrap: break-word;">rekonq doesn't use exactly the same convention as KDE.
<a href="http://gitweb.kde.org/rekonq.git/blob/HEAD:/scripts/codingstyle.sh" target="_blank">http://gitweb.kde.org/rekonq.git/blob/HEAD:/scripts/codingstyle.sh</a></pre></div></div></blockquote></div><br>--<br>Pierre<br>