D19077: Redesign the theme preview window

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:81
> This is a word puzzle and will lead to bad translations because translators won't be able to figure out what `", by "` refers to. The string should be like this instead:
> 
> `i18n("%1, by %2 (%3)", description, authorName, license)`
> 
> Of course if there's a chance any of those strings might be unset or empty, you'll need to handle that in the code or else the empty string will mess up the `i18n()` call.

>   you'll need to handle that in the code

How to do this? Sometimes some information really is missing so it could be an issue.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190225/7bc76341/attachment.html>