D19077: Redesign the theme preview window

Krešimir Čohar noreply at phabricator.kde.org
Sat Feb 23 21:15:38 GMT 2019


rooty added a comment.


  In D19077#417814 <https://phabricator.kde.org/D19077#417814>, @ngraham wrote:
  
  >
  
  
  
  
  > I'm not thrilled by the need to introduce new warnings in order to implement a hack. It's all a pretty stinky code smell, to be honest. :) Maybe @davidedmundson has some ideas.
  
  Sure. But in case he doesn't I don't think it should be dismissed - the code works (and is used elsewhere I think) and is fairly innocuous.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190223/3799f772/attachment.html>


More information about the Plasma-devel mailing list