D19077: Redesign the theme preview window

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> filipf wrote in main.qml:81
> >   you'll need to handle that in the code
> 
> How to do this? Sometimes some information really is missing so it could be an issue.

Then you'll need to have separate strings based on what could be missing. For example if only the authorName could be missing, you do this:

  text: if (authorname.length() === 0) {
          return i18n("%1 (%3)", description, license)
      } else {
          return i18n("%1, by %2 (%3)", description, authorName, license)
      }

If both authorName and license could be missing you'd need to add more conditions.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190225/125b0485/attachment-0001.html>