D6697: Allow to change toolbar font separately again

[Fabian Vogt]

fvogt added a comment.


  Looks good to me as well (+ the other patch), I just added two comments.

INLINE COMMENTS

> fonts_global_toolbar.pl:12
> +{
> +    chomp;
> +    $generalFont = $1 if ($_ =~ /font=(.*)/);

Not sure, but maybe the script should only read/change the `[General]` section?

> fonts_global_toolbar.pl:14
> +    $generalFont = $1 if ($_ =~ /font=(.*)/);
> +    s/toolBarFont=.*/toolBarFont=$generalFont/;
> +    print "$_\n";

Is it guaranteed that `font=` comes before `toolBarFont`?

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  Plasma/5.10

REVISION DETAIL
  https://phabricator.kde.org/D6697

To: rkflx, #plasma, davidedmundson
Cc: fvogt, davidedmundson, jensreuterberg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170819/13e77c61/attachment.html>