<table><tr><td style="">fvogt added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6697" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Looks good to me as well (+ the other patch), I just added two comments.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6697#inline-30166" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fonts_global_toolbar.pl:12</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="s s-Atom">chomp</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="err">$</span><span class="s s-Atom">generalFont</span> <span style="color: #aa2211">=</span> <span class="err">$</span><span style="color: #601200">1</span> <span style="color: #004012">if</span> <span class="p">(</span><span class="err">$</span><span style="color: #aa4000">_</span> <span class="s s-Atom">=~</span> <span style="color: #aa2211">/</span><span class="s s-Atom">font=</span><span class="p">(.</span><span class="s s-Atom">*</span><span class="p">)</span><span class="s s-Atom">/</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not sure, but maybe the script should only read/change the <tt style="background: #ebebeb; font-size: 13px;">[General]</tt> section?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6697#inline-30167" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fonts_global_toolbar.pl:14</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="err">$</span><span class="s s-Atom">generalFont</span> <span style="color: #aa2211">=</span> <span class="err">$</span><span style="color: #601200">1</span> <span style="color: #004012">if</span> <span class="p">(</span><span class="err">$</span><span style="color: #aa4000">_</span> <span class="s s-Atom">=~</span> <span style="color: #aa2211">/</span><span class="s s-Atom">font=</span><span class="p">(.</span><span class="s s-Atom">*</span><span class="p">)</span><span class="s s-Atom">/</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="s s-Atom">s</span><span style="color: #aa2211">/</span><span class="s s-Atom">toolBarFont=.*/toolBarFont=</span><span class="err">$</span><span class="s s-Atom">generalFont/</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="s s-Atom">print</span> <span style="color: #766510">"$_\n"</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is it guaranteed that <tt style="background: #ebebeb; font-size: 13px;">font=</tt> comes before <tt style="background: #ebebeb; font-size: 13px;">toolBarFont</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R135 Integration for Qt applications in Plasma</div></div></div><br /><div><strong>BRANCH</strong><div><div>Plasma/5.10</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6697" rel="noreferrer">https://phabricator.kde.org/D6697</a></div></div><br /><div><strong>To: </strong>rkflx, Plasma, davidedmundson<br /><strong>Cc: </strong>fvogt, davidedmundson, jensreuterberg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, abetts, sebas, apol, mart, lukas<br /></div>