[Differential] [Updated] D1931: Avoid asking model to create string-serialized icon data where possible.

[dfaure (David Faure)]

dfaure added a comment.


  Maybe it should have been the other way around, LauncherUrlWithIcon where needed ;-)
   (it seems the icon is only rarely needed)

INLINE COMMENTS

> ContextMenu.qml:225
>              } else {
> -                tasksModel.requestAddLauncher(visualParent.launcherUrl);
> +                tasksModel.requestAddLauncher(visualParent.launcherUrl());
>              }

Is it expected that requestRemoveLauncher is "without icon" and requestAddLauncher is "with icon"? Seems asymmetric but I don't know enough about this to know if it's ok or not.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1931

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, dfaure
Cc: plasma-devel, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160617/081f2195/attachment-0001.html>