<table><tr><td style="">dfaure added a comment.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1931" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Maybe it should have been the other way around, LauncherUrlWithIcon where needed ;-)<br />
 (it seems the icon is only rarely needed)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1931#inline-7391" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ContextMenu.qml:225</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                <span style="color: #004012">tasksModel</span><span class="p">.</span><span style="color: #004012">requestAddLauncher</span><span class="p">(</span><span style="color: #004012">visualParent</span><span class="p">.</span><span style="color: #004012">launcherUrl</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span style="color: #004012">tasksModel</span><span class="p">.</span><span style="color: #004012">requestAddLauncher</span><span class="p">(</span><span style="color: #004012">visualParent</span><span class="p">.</span><span style="color: #004012">launcherUrl<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">()</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is it expected that requestRemoveLauncher is "without icon" and requestAddLauncher is "with icon"? Seems asymmetric but I don't know enough about this to know if it's ok or not.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMADESKTOP Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1931" rel="noreferrer">https://phabricator.kde.org/D1931</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>hein, dfaure<br /><strong>Cc: </strong>plasma-devel, jensreuterberg, sebas<br /></div>