Review Request: Improve formatting of the events display on the calendar (applet)

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102293/#review5757
-----------------------------------------------------------

Ship it!


one small comment, but otherwise looks good. thanks for the patch! please commit at your convenience...


libs/plasmaclock/calendar.cpp
<http://git.reviewboard.kde.org/r/102293/#comment5111>

    perhaps this should be in em's instead of px? e.g. 1em or some similar good looking amount?


- Aaron J.


On Aug. 15, 2011, 10:49 p.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102293/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2011, 10:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> QDate::toString()'s date formatting doesn't work nicely for all languages and calendar systems, so changed to use KCalendarSystem for it. Also decreases indentation so less space is wasted horizontally.
> 
> 
> Diffs
> -----
> 
>   libs/plasmaclock/calendar.cpp e1c7bc6 
> 
> Diff: http://git.reviewboard.kde.org/r/102293/diff
> 
> 
> Testing
> -------
> 
> Compiles, formatting works. See screenshots
> 
> 
> Screenshots
> -----------
> 
> Coptic calendar
>   http://git.reviewboard.kde.org/r/102293/s/229/
> Correct Finnish formatting
>   http://git.reviewboard.kde.org/r/102293/s/230/
> English (US) formatting
>   http://git.reviewboard.kde.org/r/102293/s/231/
> 
> 
> Thanks,
> 
> Lasse
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110816/c088e4bd/attachment.html>