Review Request: Improve formatting of the events display on the calendar (applet)

[Lasse Liehu]

> On Aug. 16, 2011, 9:03 p.m., Aaron J. Seigo wrote:
> > libs/plasmaclock/calendar.cpp, line 433
> > <http://git.reviewboard.kde.org/r/102293/diff/1/?file=31667#file31667line433>
> >
> >     perhaps this should be in em's instead of px? e.g. 1em or some similar good looking amount?

sure. it was just text-indent (that I tried, but which was of course no good) that supported only pixels in qt


- Lasse


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102293/#review5757
-----------------------------------------------------------


On Aug. 17, 2011, 7:03 a.m., Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102293/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2011, 7:03 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> QDate::toString()'s date formatting doesn't work nicely for all languages and calendar systems, so changed to use KCalendarSystem for it. Also decreases indentation so less space is wasted horizontally.
> 
> 
> Diffs
> -----
> 
>   libs/plasmaclock/calendar.cpp e1c7bc6 
> 
> Diff: http://git.reviewboard.kde.org/r/102293/diff
> 
> 
> Testing
> -------
> 
> Compiles, formatting works. See screenshots
> 
> 
> Screenshots
> -----------
> 
> Coptic calendar
>   http://git.reviewboard.kde.org/r/102293/s/229/
> Correct Finnish formatting
>   http://git.reviewboard.kde.org/r/102293/s/230/
> English (US) formatting
>   http://git.reviewboard.kde.org/r/102293/s/231/
> 
> 
> Thanks,
> 
> Lasse
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110817/1a9b7e3f/attachment-0001.html>