Review Request: Improve formatting of the events display on the calendar (applet)
Lasse Liehu
lliehu at kolumbus.fi
Mon Aug 15 22:49:24 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102293/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
QDate::toString()'s date formatting doesn't work nicely for all languages and calendar systems, so changed to use KCalendarSystem for it. Also decreases indentation so less space is wasted horizontally.
Diffs
-----
libs/plasmaclock/calendar.cpp e1c7bc6
Diff: http://git.reviewboard.kde.org/r/102293/diff
Testing
-------
Compiles, formatting works. See screenshots
Screenshots
-----------
Coptic calendar
http://git.reviewboard.kde.org/r/102293/s/229/
Correct Finnish formatting
http://git.reviewboard.kde.org/r/102293/s/230/
English (US) formatting
http://git.reviewboard.kde.org/r/102293/s/231/
Thanks,
Lasse
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110815/010861a4/attachment-0001.html>
More information about the Plasma-devel
mailing list