<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102293/">http://git.reviewboard.kde.org/r/102293/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">one small comment, but otherwise looks good. thanks for the patch! please commit at your convenience...</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102293/diff/1/?file=31667#file31667line433" style="color: black; font-weight: bold; text-decoration: underline;">libs/plasmaclock/calendar.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool CalendarPrivate::addDateDetailsToDisplay(QString &html, const QDate &date)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">432</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="o">+=</span> <span class="s">"<li>"</span> <span class="o">+</span> <span class="n">detail</span> <span class="o">+</span> <span class="s">"</li>"</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">433</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">html</span><span class="o">+=</span> <span class="s">"<li<span class="hl"> style='margin-left: 25px;'</span>>"</span> <span class="o">+</span> <span class="n">detail</span> <span class="o">+</span> <span class="s">"</li>"</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">perhaps this should be in em's instead of px? e.g. 1em or some similar good looking amount?</pre>
</div>
<br />
<p>- Aaron J.</p>
<br />
<p>On August 15th, 2011, 10:49 p.m., Lasse Liehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Lasse Liehu.</div>
<p style="color: grey;"><i>Updated Aug. 15, 2011, 10:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">QDate::toString()'s date formatting doesn't work nicely for all languages and calendar systems, so changed to use KCalendarSystem for it. Also decreases indentation so less space is wasted horizontally.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, formatting works. See screenshots</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmaclock/calendar.cpp <span style="color: grey">(e1c7bc6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102293/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102293/s/229/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/15/screenshot2_400x100.png" style="border: 1px black solid;" alt="Coptic calendar" /></a>
<a href="http://git.reviewboard.kde.org/r/102293/s/230/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/15/screenshot1_400x100.png" style="border: 1px black solid;" alt="Correct Finnish formatting" /></a>
<a href="http://git.reviewboard.kde.org/r/102293/s/231/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/15/screenshot3_400x100.png" style="border: 1px black solid;" alt="English (US) formatting" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>