Review Request: Make custom colours work on the digital clock again

Alex Merry kde at
Thu Nov 4 03:07:24 CET 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-11-04 02:07:24.050751)

Review request for Plasma.


Screenshot included.

I made disabling the shadow an option because that's the only way I can get anything that looks half decent on my desktop (I have the default panel at the top of the screen with Fresh Morning as my background - the panel is translucent, so the theme's default colours look really bad and are hard to read, but plain solid white looks fine.

The reason this is a combined feature/bug fix is because I couldn't figure out a sensible way to fix the bug without including the option to change the shadow (given that black text with a black shadow, for example, is not a sensible combination).  Well, other than removing the option to set the text colour altogether, but that would give me an ugly, hard-to-read clock.


Since the shadow was introduced for the digital clock a few weeks ago, the custom colour setting has been ignored.  This re-enables it, and also allows the user to choose a shadow colour.

This changes the configuration dialog and introduces a new option, which is why I'm submitting it for review before committing.


  /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.h 1191270 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.cpp 1191270 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clockConfig.ui 1191270 



Changing, saving and loading the settings worked in plasmoid-viewer.


The changed configuration



-------------- next part --------------
An HTML attachment was scrubbed...

More information about the Plasma-devel mailing list