<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5747/">http://svn.reviewboard.kde.org/r/5747/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated 2010-11-04 02:07:24.050751</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Screenshot included.
I made disabling the shadow an option because that's the only way I can get anything that looks half decent on my desktop (I have the default panel at the top of the screen with Fresh Morning as my background - the panel is translucent, so the theme's default colours look really bad and are hard to read, but plain solid white looks fine.
The reason this is a combined feature/bug fix is because I couldn't figure out a sensible way to fix the bug without including the option to change the shadow (given that black text with a black shadow, for example, is not a sensible combination). Well, other than removing the option to set the text colour altogether, but that would give me an ugly, hard-to-read clock.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since the shadow was introduced for the digital clock a few weeks ago, the custom colour setting has been ignored. This re-enables it, and also allows the user to choose a shadow colour.
This changes the configuration dialog and introduces a new option, which is why I'm submitting it for review before committing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changing, saving and loading the settings worked in plasmoid-viewer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.h <span style="color: grey">(1191270)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.cpp <span style="color: grey">(1191270)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clockConfig.ui <span style="color: grey">(1191270)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5747/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5747/s/546/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/11/04/clock-config_400x100.png" style="border: 1px black solid;" alt="The changed configuration" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>