Review Request: Make custom colours work on the digital clock again

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5747/#review8503
-----------------------------------------------------------

Ship it!


Patch looks good and fixes a couple of problems with the newly introduced shadow.

I'm not 100% sure about the new config option, but I also don't see another way to get it right without it.

- Sebastian


On 2010-11-04 02:07:24, Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5747/
> -----------------------------------------------------------
> 
> (Updated 2010-11-04 02:07:24)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Since the shadow was introduced for the digital clock a few weeks ago, the custom colour setting has been ignored.  This re-enables it, and also allows the user to choose a shadow colour.
> 
> This changes the configuration dialog and introduces a new option, which is why I'm submitting it for review before committing.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.h 1191270 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.cpp 1191270 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clockConfig.ui 1191270 
> 
> Diff: http://svn.reviewboard.kde.org/r/5747/diff
> 
> 
> Testing
> -------
> 
> Changing, saving and loading the settings worked in plasmoid-viewer.
> 
> 
> Screenshots
> -----------
> 
> The changed configuration
>   http://svn.reviewboard.kde.org/r/5747/s/546/
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101104/9e62f303/attachment.htm