Review Request: Make custom colours work on the digital clock again

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5747/#review8501
-----------------------------------------------------------


can you include a screenshot of the changed config? i also wonder about the value of making the shadow optional (other than "because we can"). 

p.s. it's a little unfortunate that this review mixes both a bug fix and a new feature.

- Aaron


On 2010-11-01 18:42:29, Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5747/
> -----------------------------------------------------------
> 
> (Updated 2010-11-01 18:42:29)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Since the shadow was introduced for the digital clock a few weeks ago, the custom colour setting has been ignored.  This re-enables it, and also allows the user to choose a shadow colour.
> 
> This changes the configuration dialog and introduces a new option, which is why I'm submitting it for review before committing.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.h 1191270 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.cpp 1191270 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clockConfig.ui 1191270 
> 
> Diff: http://svn.reviewboard.kde.org/r/5747/diff
> 
> 
> Testing
> -------
> 
> Changing, saving and loading the settings worked in plasmoid-viewer.
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101104/e27eb0e2/attachment.html