[Panel-devel] Hello

[William Egert]

On Dec 10, 2007 7:39 PM, Aaron J. Seigo <aseigo at kde.org> wrote:

> On Monday 10 December 2007, William Egert wrote:
> > I subscribed to this list awhile ago and am trying to wrap my head
> around
> > stuff and get involved with KDE.  Today was my first adventure in
> actually
>
> welcome to the project =)


Thanks :)

>
>
> > It doesn't really fix anything except for maybe some memory leaks, but
> is
> > mainly what I see as some code clean-up.  I was hoping somebody could
> just
> > look it over and tell me if it is decent enough that it is something i
>
> this is sebas' code, but i'll provide a couple of comments anyways:


much appreciated

>
>
> - early returns being sloppy or not really depends on two things: personal
> aesthetics and the code itself. if there is a bunch of state setting to be
> done and is therefore duplicated at each return, then yes, it can be
> considered sloppy. if there is no state to reset it can often make the
> code
> rather nicer to read as you don't have great nested blocks of code to
> track.


true, should have removed that comment

>
>
> - memory leaks: deleting m_layout isn't necessary. it is owned by the
> dialog
> (setLayout transfers ownership) and so will be deleted when the dialog is.
> the dialog does indeed need to be deleted however. good catch.


good to know!
I also found a bug while using plasmoidviewer (really neat tool)  I will
attach another patch with the fix.  The bug was that you had to click the
clock 3 times for the calendar to be displayed.  This patch fixes the clock,
but it does look like Plasma::Dialog eats up a click event?  For example, if
i click so the calender is displayed, and then click on an open application,
the calendar will hide, but the application did not gain focus.

-Bill

>
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Trolltech
>
> _______________________________________________
> Panel-devel mailing list
> Panel-devel at kde.org
> https://mail.kde.org/mailman/listinfo/panel-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/panel-devel/attachments/20071210/aa28a856/attachment-0001.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clock2.diff
Type: text/x-diff
Size: 12458 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071210/aa28a856/attachment-0001.bin