[Panel-devel] Hello

[Aaron J. Seigo]

On Monday 10 December 2007, William Egert wrote:
> I subscribed to this list awhile ago and am trying to wrap my head around
> stuff and get involved with KDE.  Today was my first adventure in actually

welcome to the project =)

> It doesn't really fix anything except for maybe some memory leaks, but is
> mainly what I see as some code clean-up.  I was hoping somebody could just
> look it over and tell me if it is decent enough that it is something i

this is sebas' code, but i'll provide a couple of comments anyways:

- early returns being sloppy or not really depends on two things: personal 
aesthetics and the code itself. if there is a bunch of state setting to be 
done and is therefore duplicated at each return, then yes, it can be 
considered sloppy. if there is no state to reset it can often make the code 
rather nicer to read as you don't have great nested blocks of code to track.

- memory leaks: deleting m_layout isn't necessary. it is owned by the dialog 
(setLayout transfers ownership) and so will be deleted when the dialog is. 
the dialog does indeed need to be deleted however. good catch.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071210/92199ae4/attachment.pgp