[Panel-devel] Hello

[Aaron J. Seigo]

On Monday 10 December 2007, William Egert wrote:
> On Dec 10, 2007 7:39 PM, Aaron J. Seigo <aseigo at kde.org> wrote:
> clock 3 times for the calendar to be displayed.  This patch fixes the
> clock, 

ah, something i forgot to mention that i noticed on first read of the patch is 
that you should not be initializing the dialogs in the constructor. that just 
slows down start up time and may unecessarily use up memory (what if the user 
never clicks to get the calendar?) ... there's a reason it is initialized in 
the mouseClickEvent =)

also, i'm not sure what the point of m_calendarIsShown is when one can simply 
query isVisible()?

apologies for not putting that in the earlier email... 

> but it does look like Plasma::Dialog eats up a click event?  For 
> example, if i click so the calender is displayed, and then click on an open
> application, the calendar will hide, but the application did not gain
> focus.

that would be a side effect of setting the calendar window type to Popup. 
personally, i'd set it to be a toolbox window and only close it on an 
explicit close.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/panel-devel/attachments/20071210/aa977488/attachment.pgp