<br><br><div class="gmail_quote">On Dec 10, 2007 7:39 PM, Aaron J. Seigo <<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">On Monday 10 December 2007, William Egert wrote:<br>> I subscribed to this list awhile ago and am trying to wrap my head around<br>> stuff and get involved with KDE. Today was my first adventure in actually
<br><br></div>welcome to the project =)</blockquote><div><br>Thanks :) <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><div class="Ih2E3d">
<br>> It doesn't really fix anything except for maybe some memory leaks, but is<br>> mainly what I see as some code clean-up. I was hoping somebody could just<br>> look it over and tell me if it is decent enough that it is something i
<br><br></div>this is sebas' code, but i'll provide a couple of comments anyways:</blockquote><div><br>much appreciated <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br><br>- early returns being sloppy or not really depends on two things: personal<br>aesthetics and the code itself. if there is a bunch of state setting to be<br>done and is therefore duplicated at each return, then yes, it can be
<br>considered sloppy. if there is no state to reset it can often make the code<br>rather nicer to read as you don't have great nested blocks of code to track.</blockquote><div><br>true, should have removed that comment
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><br>- memory leaks: deleting m_layout isn't necessary. it is owned by the dialog
<br>(setLayout transfers ownership) and so will be deleted when the dialog is.<br>the dialog does indeed need to be deleted however. good catch.</blockquote><div><br>good to know! <br>I also found a bug while using plasmoidviewer (really neat tool) I will attach another patch with the fix. The bug was that you had to click the clock 3 times for the calendar to be displayed. This patch fixes the clock, but it does look like Plasma::Dialog eats up a click event? For example, if i click so the calender is displayed, and then click on an open application, the calendar will hide, but the application did not gain focus.
<br><br>-Bill<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><font color="#888888"><br>--<br>Aaron J. Seigo<br>humru othro a kohnu se
<br>GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43<br><br>KDE core developer sponsored by Trolltech<br></font><br>_______________________________________________<br>Panel-devel mailing list<br><a href="mailto:Panel-devel@kde.org">
Panel-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/panel-devel" target="_blank">https://mail.kde.org/mailman/listinfo/panel-devel</a><br><br></blockquote></div><br>