[Marble-devel] Review Request 111499: GroundOverlay Rendering

[Adrian Draghici]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111499/
-----------------------------------------------------------

(Updated July 20, 2013, 12:02 p.m.)


Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.


Changes
-------

This version removes unnecessary cast and doesn't cache QImages anymore, using qLowerBound to search for overlays when adding and removing.

Points left are: fixing the rendering in Mercator projection and taking care not to render on the Atlas Map.


Description
-------

This patch adds support for rendering GroundOverlays. A model with filtered GroundOverlays is saved in MarbleModel and used in TextureLayer, where the cache of GroundOverlays is handled. The actual rendering takes place in MergedLayerDecorator.


Diffs (updated)
-----

  src/lib/MarbleMap.cpp 102ed0d 
  src/lib/MarbleModel.h 44a5f61 
  src/lib/MarbleModel.cpp 3c44f9d 
  src/lib/MergedLayerDecorator.h 2823cfc 
  src/lib/MergedLayerDecorator.cpp 6363d8e 
  src/lib/geodata/data/GeoDataGroundOverlay.h 2e144af 
  src/lib/layers/GeometryLayer.cpp 20fd6a7 
  src/lib/layers/TextureLayer.h 1dbd114 
  src/lib/layers/TextureLayer.cpp 5b9e9c9 

Diff: http://git.reviewboard.kde.org/r/111499/diff/


Testing
-------

Tested with multiple overlapping overlays, different rotation angles.


Thanks,

Adrian Draghici

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130720/37a9cb9f/attachment.html>