[Marble-devel] Review Request 111499: GroundOverlay Rendering

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111499/#review36084
-----------------------------------------------------------



src/lib/geodata/data/GeoDataGroundOverlay.h
<http://git.reviewboard.kde.org/r/111499/#comment26733>

    Please remove this general comparison method entirely in favor of a purpose-specific comparison function (see below).



src/lib/layers/TextureLayer.cpp
<http://git.reviewboard.kde.org/r/111499/#comment26737>

    Please remove usage of QPair to build a plain QList<const GeoDataGroundOverlay *>. Rely on GeoDataGroundOverlay::icon() to return the QImage.



src/lib/layers/TextureLayer.cpp
<http://git.reviewboard.kde.org/r/111499/#comment26736>

    These two lines cause compile issues. Please fix.



src/lib/layers/TextureLayer.cpp
<http://git.reviewboard.kde.org/r/111499/#comment26735>

    Please get an iterator using qLowerBound to determine the insert position. Moreover, please pass a custom comparison function to qLowerBound, e.g. "drawOrderLessThan", instead of relying on GeoDataGroundOverlay::operator<().


- Bernhard Beschow


On July 15, 2013, 11:30 a.m., Adrian Draghici wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111499/
> -----------------------------------------------------------
> 
> (Updated July 15, 2013, 11:30 a.m.)
> 
> 
> Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> This patch adds support for rendering GroundOverlays. A model with filtered GroundOverlays is saved in MarbleModel and used in TextureLayer, where the cache of GroundOverlays is handled. The actual rendering takes place in MergedLayerDecorator.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleMap.cpp 102ed0d 
>   src/lib/MarbleModel.h 44a5f61 
>   src/lib/MarbleModel.cpp 3c44f9d 
>   src/lib/MergedLayerDecorator.h 2823cfc 
>   src/lib/MergedLayerDecorator.cpp 6363d8e 
>   src/lib/geodata/data/GeoDataGroundOverlay.h 2e144af 
>   src/lib/geodata/data/GeoDataGroundOverlay.cpp 0a87dc4 
>   src/lib/layers/GeometryLayer.cpp 20fd6a7 
>   src/lib/layers/TextureLayer.h 1dbd114 
>   src/lib/layers/TextureLayer.cpp 5b9e9c9 
> 
> Diff: http://git.reviewboard.kde.org/r/111499/diff/
> 
> 
> Testing
> -------
> 
> Tested with multiple overlapping overlays, different rotation angles.
> 
> 
> Thanks,
> 
> Adrian Draghici
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130717/7db8da8e/attachment.html>