<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111499/">http://git.reviewboard.kde.org/r/111499/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.</div>
<div>By Adrian Draghici.</div>
<p style="color: grey;"><i>Updated July 20, 2013, 12:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This version removes unnecessary cast and doesn't cache QImages anymore, using qLowerBound to search for overlays when adding and removing.
Points left are: fixing the rendering in Mercator projection and taking care not to render on the Atlas Map.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds support for rendering GroundOverlays. A model with filtered GroundOverlays is saved in MarbleModel and used in TextureLayer, where the cache of GroundOverlays is handled. The actual rendering takes place in MergedLayerDecorator.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with multiple overlapping overlays, different rotation angles.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/MarbleMap.cpp <span style="color: grey">(102ed0d)</span></li>
<li>src/lib/MarbleModel.h <span style="color: grey">(44a5f61)</span></li>
<li>src/lib/MarbleModel.cpp <span style="color: grey">(3c44f9d)</span></li>
<li>src/lib/MergedLayerDecorator.h <span style="color: grey">(2823cfc)</span></li>
<li>src/lib/MergedLayerDecorator.cpp <span style="color: grey">(6363d8e)</span></li>
<li>src/lib/geodata/data/GeoDataGroundOverlay.h <span style="color: grey">(2e144af)</span></li>
<li>src/lib/layers/GeometryLayer.cpp <span style="color: grey">(20fd6a7)</span></li>
<li>src/lib/layers/TextureLayer.h <span style="color: grey">(1dbd114)</span></li>
<li>src/lib/layers/TextureLayer.cpp <span style="color: grey">(5b9e9c9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111499/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>