[Marble-devel] Review Request 111499: GroundOverlay Rendering

[Konrad Enzensberger]

Hi Adrian,

i tested you first version, it works.
After updating to this modified version i am facing a problem.

In TextureLayer::addGroundOverlays(...) i allways get NULL for this cast:
const GeoDataGroundOverlay *overlay = static_cast<GeoDataGroundOverlay *>(qvariant_cast<GeoDataObject *>( index.data( MarblePlacemarkModel::ObjectPointerRole ) ) );

The previous casting version worked.
Like mentioned by dennis adding :

Q_DECLARE_METATYPE( Marble::GeoDataGroundOverlay* )

to GroundOverlay header seems not to be enough.
Are this cast is working for you ? I tested on Win7,

br, konrad 

  ----- Original Message ----- 
  From: Adrian Draghici 
  To: Thibaut Gridel ; Torsten Rahn ; Bernhard Beschow ; Dennis Nienhüser 
  Cc: Marble 
  Sent: Saturday, July 20, 2013 2:02 PM
  Subject: Re: [Marble-devel] Review Request 111499: GroundOverlay Rendering


        This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111499/  

        Review request for Marble, Bernhard Beschow, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.
        By Adrian Draghici.
        Updated July 20, 2013, 12:02 p.m.

        Changes
This version removes unnecessary cast and doesn't cache QImages anymore, using qLowerBound to search for overlays when adding and removing.

Points left are: fixing the rendering in Mercator projection and taking care not to render on the Atlas Map. 

        Description 
This patch adds support for rendering GroundOverlays. A model with filtered GroundOverlays is saved in MarbleModel and used in TextureLayer, where the cache of GroundOverlays is handled. The actual rendering takes place in MergedLayerDecorator. 

        Testing 
Tested with multiple overlapping overlays, different rotation angles. 

        Diffs (updated)
          a.. src/lib/MarbleMap.cpp (102ed0d) 
          b.. src/lib/MarbleModel.h (44a5f61) 
          c.. src/lib/MarbleModel.cpp (3c44f9d) 
          d.. src/lib/MergedLayerDecorator.h (2823cfc) 
          e.. src/lib/MergedLayerDecorator.cpp (6363d8e) 
          f.. src/lib/geodata/data/GeoDataGroundOverlay.h (2e144af) 
          g.. src/lib/layers/GeometryLayer.cpp (20fd6a7) 
          h.. src/lib/layers/TextureLayer.h (1dbd114) 
          i.. src/lib/layers/TextureLayer.cpp (5b9e9c9) 
        View Diff
       



------------------------------------------------------------------------------


  _______________________________________________
  Marble-devel mailing list
  Marble-devel at kde.org
  https://mail.kde.org/mailman/listinfo/marble-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20130720/89505c5f/attachment.html>