[Marble-devel] Review Request 113904: ESA SoCIS 2013 - Move SolarSystem 2013 libs into marble central place

[Marek Hakala]

> On Nov. 20, 2013, 12:29 p.m., René Küttner wrote:
> > Marek: It seems like you mixed up moving the astro libs and adding plugin controlled menu entries in this diff. Could you remove the changes not related astro lis from this diff? You may add them as a separate review request?
> 
> René Küttner wrote:
>     A typo slipped in by accident. I meant: "remove the changes not related to astro libs"

Rene: Sorry for mixing two different things. I divided the patch into two patches SolarSystem library and EclipsePlugin rebase. 


- Marek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113904/#review44036
-----------------------------------------------------------


On Dec. 3, 2013, 1:37 a.m., Marek Hakala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113904/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 1:37 a.m.)
> 
> 
> Review request for Marble, Torsten Rahn and René Küttner.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> ESA SoCIS 2013 - Move SolarSystem 2013 libs into marble central place
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 1578335 
>   src/lib/astro/CMakeLists.txt PRE-CREATION 
>   src/lib/astro/README PRE-CREATION 
>   src/lib/astro/astr2lib.h PRE-CREATION 
>   src/lib/astro/astr2lib.cpp PRE-CREATION 
>   src/lib/astro/astrolib.h PRE-CREATION 
>   src/lib/astro/astrolib.cpp PRE-CREATION 
>   src/lib/astro/astrolib_export.h PRE-CREATION 
>   src/lib/astro/attlib.h PRE-CREATION 
>   src/lib/astro/attlib.cpp PRE-CREATION 
>   src/lib/astro/eclsolar.h PRE-CREATION 
>   src/lib/astro/eclsolar.cpp PRE-CREATION 
>   src/lib/astro/planetarySats.h PRE-CREATION 
>   src/lib/astro/planetarySats.cpp PRE-CREATION 
>   src/lib/astro/solarsystem.h PRE-CREATION 
>   src/lib/astro/solarsystem.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113904/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marek Hakala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131203/3f9dfb8d/attachment.html>