[Marble-devel] Review Request 113904: ESA SoCIS 2013 - Move SolarSystem 2013 libs into marble central place

[Marek Hakala]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113904/
-----------------------------------------------------------

(Updated Dec. 3, 2013, 1:37 a.m.)


Review request for Marble, Torsten Rahn and René Küttner.


Changes
-------

I implement the following recommendations:

1) astro is a separate library bundled with Marble. That would mean
  - files in src/lib/astro
  - headers go to include/astro
  - no use of Marble namespace
  - no use of any other Marble resources, e.g. the export headers
  - created as a shared library on its own linked to libmarblewidget (for the time being we could do a static library similar to src/apps/marble-ui)


Repository: marble


Description
-------

ESA SoCIS 2013 - Move SolarSystem 2013 libs into marble central place


Diffs (updated)
-----

  src/CMakeLists.txt 1578335 
  src/lib/astro/CMakeLists.txt PRE-CREATION 
  src/lib/astro/README PRE-CREATION 
  src/lib/astro/astr2lib.h PRE-CREATION 
  src/lib/astro/astr2lib.cpp PRE-CREATION 
  src/lib/astro/astrolib.h PRE-CREATION 
  src/lib/astro/astrolib.cpp PRE-CREATION 
  src/lib/astro/astrolib_export.h PRE-CREATION 
  src/lib/astro/attlib.h PRE-CREATION 
  src/lib/astro/attlib.cpp PRE-CREATION 
  src/lib/astro/eclsolar.h PRE-CREATION 
  src/lib/astro/eclsolar.cpp PRE-CREATION 
  src/lib/astro/planetarySats.h PRE-CREATION 
  src/lib/astro/planetarySats.cpp PRE-CREATION 
  src/lib/astro/solarsystem.h PRE-CREATION 
  src/lib/astro/solarsystem.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113904/diff/


Testing
-------


Thanks,

Marek Hakala

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131203/c547f45d/attachment.html>