[Marble-devel] Review Request 113904: ESA SoCIS 2013 - Move SolarSystem 2013 libs into marble central place

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113904/#review45502
-----------------------------------------------------------


Disclaimer: My review does not include a review of the actual code.

The license headers should be standardized.

Would be good to test this on Win/Mac as well. Does not need to be part of the review though.



src/lib/astro/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113904/#comment32455>

    shouldn't be needed here, we have it at the toplevel CMakeLists.txt



src/lib/astro/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113904/#comment32456>

    -DKML_LAZY_IMP affects marble, but shouldn't be needed here


- Dennis Nienhüser


On Dec. 3, 2013, 12:37 a.m., Marek Hakala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113904/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 12:37 a.m.)
> 
> 
> Review request for Marble, Torsten Rahn and René Küttner.
> 
> 
> Repository: marble
> 
> 
> Description
> -------
> 
> ESA SoCIS 2013 - Move SolarSystem 2013 libs into marble central place
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 1578335 
>   src/lib/astro/CMakeLists.txt PRE-CREATION 
>   src/lib/astro/README PRE-CREATION 
>   src/lib/astro/astr2lib.h PRE-CREATION 
>   src/lib/astro/astr2lib.cpp PRE-CREATION 
>   src/lib/astro/astrolib.h PRE-CREATION 
>   src/lib/astro/astrolib.cpp PRE-CREATION 
>   src/lib/astro/astrolib_export.h PRE-CREATION 
>   src/lib/astro/attlib.h PRE-CREATION 
>   src/lib/astro/attlib.cpp PRE-CREATION 
>   src/lib/astro/eclsolar.h PRE-CREATION 
>   src/lib/astro/eclsolar.cpp PRE-CREATION 
>   src/lib/astro/planetarySats.h PRE-CREATION 
>   src/lib/astro/planetarySats.cpp PRE-CREATION 
>   src/lib/astro/solarsystem.h PRE-CREATION 
>   src/lib/astro/solarsystem.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113904/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marek Hakala
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20131210/5e5455b1/attachment.html>