<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113904/">http://git.reviewboard.kde.org/r/113904/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 20th, 2013, 12:29 p.m. CET, <b>René Küttner</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Marek: It seems like you mixed up moving the astro libs and adding plugin controlled menu entries in this diff. Could you remove the changes not related astro lis from this diff? You may add them as a separate review request?</pre>
</blockquote>
<p>On November 20th, 2013, 12:40 p.m. CET, <b>René Küttner</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A typo slipped in by accident. I meant: "remove the changes not related to astro libs"</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rene: Sorry for mixing two different things. I divided the patch into two patches SolarSystem library and EclipsePlugin rebase. </pre>
<br />
<p>- Marek</p>
<br />
<p>On December 3rd, 2013, 1:37 a.m. CET, Marek Hakala wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Marble, Torsten Rahn and René Küttner.</div>
<div>By Marek Hakala.</div>
<p style="color: grey;"><i>Updated Dec. 3, 2013, 1:37 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ESA SoCIS 2013 - Move SolarSystem 2013 libs into marble central place</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(1578335)</span></li>
<li>src/lib/astro/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/astr2lib.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/astr2lib.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/astrolib.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/astrolib.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/astrolib_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/attlib.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/attlib.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/eclsolar.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/eclsolar.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/planetarySats.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/planetarySats.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/solarsystem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/astro/solarsystem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113904/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>