D22424: TextDocument: remove actions from contextmenu on hide already

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D22424#497204 <https://phabricator.kde.org/D22424#497204>, @rjvbb wrote:
  
  > Friedrich W. H. Kossebau wrote on 20190717::00:12:44 re: "D22424 <https://phabricator.kde.org/D22424>: TextDocument: remove actions from contextmenu on hide already"
  >
  > > This revision was not accepted when it landed; it landed in state "Needs Review".
  >
  > Hmm, since when is this acceptable?
  
  
  It is acceptable when the person doing it is semi-maintainer (by their role of release manager). The other option would have been to release 5.3.3 without a fix for ctags plugin users, rendering it unusable for people relying on packaged kdevelop. See also https://mail.kde.org/pipermail/kdevelop-devel/2019-July/063157.html
  
  > I see the same change was backported to the 5.3 branch, understandable in a way but what about the glitch I mentioned and you confirmed? Have you solved that somehow?
  
  If by glitch you mean the "Broken text-document:" log output appearing, please see my comment D22424#496348 <https://phabricator.kde.org/D22424#496348>  above, repeating here: "Playing around I finally managed to reproduce this as well. Though also for 5.3 and without this patch: seems something to do with workingsets code being eager to create TextDocument objects for any urls they have in the sessionrc file, Dumped my findings as https://bugs.kde.org/show_bug.cgi?id=409858"
  
  But you might mean some other glitch, which I have no idea right now?
  
  > FWIW I got to look at the KTE implementation of the context menu mechanism that is used here. It indeed uses and reuses a single QMenu instance (there's even a comment in the code about that).
  
  Please give links into the code, as I am lost what you exactly refer to here.

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D22424

To: kossebau, #kdevelop
Cc: anthonyfieroni, rjvbb, kdevelop-devel, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190718/1ce81323/attachment-0001.html>