D22424: TextDocument: remove actions from contextmenu on hide already

René J.V. Bertin noreply at phabricator.kde.org
Thu Jul 18 10:01:56 BST 2019


rjvbb added a comment.


  Friedrich W. H. Kossebau wrote on 20190717::00:12:44 re: "D22424 <https://phabricator.kde.org/D22424>: TextDocument: remove actions from contextmenu on hide already"
  
  > This revision was not accepted when it landed; it landed in state "Needs Review".
  
  Hmm, since when is this acceptable?
  
  I see the same change was backported to the 5.3 branch, understandable in a way but what about the glitch I mentioned and you confirmed? Have you solved that somehow?
  
  FWIW I got to look at the KTE implementation of the context menu mechanism that is used here. It indeed uses and reuses a single QMenu instance (there's even a comment in the code about that).

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D22424

To: kossebau, #kdevelop
Cc: anthonyfieroni, rjvbb, kdevelop-devel, hmitonneau, christiant, glebaccon, domson, antismap, iodelay, alexeymin, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20190718/2400353e/attachment.html>


More information about the KDevelop-devel mailing list