Review Request 114510: Proposed patch for bug 318263

[Gabriele Menna]

> On Dec. 17, 2013, 10:21 a.m., Kevin Funk wrote:
> > Also, please add some additional tests which verify that the addressed bug is fixed.

I added a patch providing a test which _should_ prove that the bug is fixed.

It proves nothing, indeed, as the test is working also with the original context.cpp.
It is working because, when evaluating the provided contexts, CodeCompletionContext
- as first wrongly replaces '.' with '->' and vice versa
- then, evaluates whether the given context is correct. But it claims that the modified context is correct because of the bug I'm trying to fix.
The only difference we get while running the tests with original and the patched context.cpp is that the code replacing '.' with '->' is not executed (checked by putting a breakpoint on it)

The feeling is that several small issues make '.' and '->' replacement quite broken.
If no valid patch is provided, please, at least disable it!


- Gabriele


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114510/#review45849
-----------------------------------------------------------


On Dec. 16, 2013, 8 p.m., Gabriele Menna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114510/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 8 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Proposed patch for bug 318263
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codecompletion/context.cpp d851050 
> 
> Diff: https://git.reviewboard.kde.org/r/114510/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gabriele Menna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140102/d431bc44/attachment.html>