Review Request 114510: Proposed patch for bug 318263

[Gabriele Menna]

> On Dec. 16, 2013, 9:51 p.m., Milian Wolff wrote:
> > this fails some tests:
> > 
> > FAIL!  : TestCppCodeCompletion::testInvalidContexts() '!invalidExp11.completionContext->isValid()' returned FALSE. ()
> >    Loc: [/home/milian/projects/kde4/kdevelop/languages/cpp/tests/test_cppcodecompletion.cpp(358)]
> > FAIL!  : TestCppCodeCompletion::testTemplateMemberAccess() Compared values are not the same
> >    Loc: [/home/milian/projects/kde4/kdevelop/languages/cpp/tests/test_cppcodecompletion.cpp(1787)]
> >

I checked the failing tests.
- testInvalidContexts() fails when checking if '::' is a valid context. In my opinion, this test is broken, as '::' is really a valid context()
- testTemplateMemberAccess(): unfortunately, my knowledge of DUChain code is too weak to figure out with a decent effort why "IntTest::" test fails...


- Gabriele


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114510/#review45827
-----------------------------------------------------------


On Dec. 16, 2013, 8 p.m., Gabriele Menna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114510/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 8 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Proposed patch for bug 318263
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codecompletion/context.cpp d851050 
> 
> Diff: https://git.reviewboard.kde.org/r/114510/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gabriele Menna
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140102/aa4cc6c9/attachment-0001.html>