<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114510/">https://git.reviewboard.kde.org/r/114510/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 17th, 2013, 10:21 a.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Also, please add some additional tests which verify that the addressed bug is fixed.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I added a patch providing a test which _should_ prove that the bug is fixed.
It proves nothing, indeed, as the test is working also with the original context.cpp.
It is working because, when evaluating the provided contexts, CodeCompletionContext
- as first wrongly replaces '.' with '->' and vice versa
- then, evaluates whether the given context is correct. But it claims that the modified context is correct because of the bug I'm trying to fix.
The only difference we get while running the tests with original and the patched context.cpp is that the code replacing '.' with '->' is not executed (checked by putting a breakpoint on it)
The feeling is that several small issues make '.' and '->' replacement quite broken.
If no valid patch is provided, please, at least disable it!</pre>
<br />
<p>- Gabriele</p>
<br />
<p>On December 16th, 2013, 8 p.m. UTC, Gabriele Menna wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Gabriele Menna.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2013, 8 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Proposed patch for bug 318263</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/codecompletion/context.cpp <span style="color: grey">(d851050)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114510/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>