Review Request: Fix regression in output filtering and improve the output

[Morten Volden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107446/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

The patch addresses two things:

a) Fix regression introduced after refactoring outputfiltering - It was not possible to click on linker errors
b) Now indicates the linker errors as errors making it visible to the user that he can click on them

Also a corrected one of the regular expressions so that it now hits on all line instances it is supposed to hit on (Come to think of it, thats three things :-) )


Diffs
-----

  outputview/outputfilteringstrategies.cpp 29f5b7e 
  outputview/tests/filteringstrategytest.cpp 0c54d43 
  outputview/tests/testlinebuilderfunctions.h 919393e 

Diff: http://git.reviewboard.kde.org/r/107446/diff/


Testing
-------

Various tests in filteringstrategytest have been expanded with cases to verify this.


Screenshots
-----------

Before
  http://git.reviewboard.kde.org/r/107446/s/852/
After
  http://git.reviewboard.kde.org/r/107446/s/853/


Thanks,

Morten Volden

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121124/bb1c027d/attachment.html>