<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107446/">http://git.reviewboard.kde.org/r/107446/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Morten Volden.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch addresses two things:
a) Fix regression introduced after refactoring outputfiltering - It was not possible to click on linker errors
b) Now indicates the linker errors as errors making it visible to the user that he can click on them
Also a corrected one of the regular expressions so that it now hits on all line instances it is supposed to hit on (Come to think of it, thats three things :-) )</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Various tests in filteringstrategytest have been expanded with cases to verify this.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>outputview/outputfilteringstrategies.cpp <span style="color: grey">(29f5b7e)</span></li>
<li>outputview/tests/filteringstrategytest.cpp <span style="color: grey">(0c54d43)</span></li>
<li>outputview/tests/testlinebuilderfunctions.h <span style="color: grey">(919393e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107446/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107446/s/852/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/24/ScreenshotBefore_400x100.png" style="border: 1px black solid;" alt="Before" /></a>
<a href="http://git.reviewboard.kde.org/r/107446/s/853/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/24/After_400x100.png" style="border: 1px black solid;" alt="After" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>