Review Request: Fix regression in output filtering and improve the output

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107446/#review22486
-----------------------------------------------------------

Ship it!


Besides those two minor issues looks good.


outputview/outputfilteringstrategies.cpp
<http://git.reviewboard.kde.org/r/107446/#comment17216>

    extra whitespace here at the end of the line.



outputview/outputfilteringstrategies.cpp
<http://git.reviewboard.kde.org/r/107446/#comment17217>

    This could also be declared static if its used just in this file.


- Andreas Pakulat


On Nov. 24, 2012, 2:45 p.m., Morten Volden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107446/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2012, 2:45 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> The patch addresses two things:
> 
> a) Fix regression introduced after refactoring outputfiltering - It was not possible to click on linker errors
> b) Now indicates the linker errors as errors making it visible to the user that he can click on them
> 
> Also a corrected one of the regular expressions so that it now hits on all line instances it is supposed to hit on (Come to think of it, thats three things :-) )
> 
> 
> Diffs
> -----
> 
>   outputview/outputfilteringstrategies.cpp 29f5b7e 
>   outputview/tests/filteringstrategytest.cpp 0c54d43 
>   outputview/tests/testlinebuilderfunctions.h 919393e 
> 
> Diff: http://git.reviewboard.kde.org/r/107446/diff/
> 
> 
> Testing
> -------
> 
> Various tests in filteringstrategytest have been expanded with cases to verify this.
> 
> 
> Screenshots
> -----------
> 
> Before
>   http://git.reviewboard.kde.org/r/107446/s/852/
> After
>   http://git.reviewboard.kde.org/r/107446/s/853/
> 
> 
> Thanks,
> 
> Morten Volden
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121124/c78df5df/attachment.html>