Review Request: Remove inconsistency in BackgroundParser internal state

Milian Wolff mail at milianw.de
Tue Mar 8 15:55:08 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100807/#review1848
-----------------------------------------------------------



language/backgroundparser/backgroundparser.h
<http://git.reviewboard.kde.org/r/100807/#comment1512>

    this breaks the API, preventing this to go into 4.2, rather create a copy of the cleaned url in the implementation and keep the interface intact


- Milian


On March 8, 2011, 1:25 p.m., Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100807/
> -----------------------------------------------------------
> 
> (Updated March 8, 2011, 1:25 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> When a document was added for parsing with multiple priorities, a default DocumentParsePlan was retrieved from m_documents when creating jobs after the first one. This led to incorrect set of features for parsing job and might trigger unnecessary reparsing when a file was reloaded.
> 
> Changed m_documents from QMap to QHash to avoid hitting https://bugs.kde.org/show_bug.cgi?id=267732.
> 
> 
> Diffs
> -----
> 
>   language/backgroundparser/backgroundparser.h a04949f26f706bcdfc3d0fa26fa7c3c16bf3509d 
>   language/backgroundparser/backgroundparser.cpp 540a453e74d4a518e54bc9b5fa0c982d76088ea1 
> 
> Diff: http://git.reviewboard.kde.org/r/100807/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110308/d9e8194f/attachment.html>


More information about the KDevelop-devel mailing list