Review Request: Remove inconsistency in BackgroundParser internal state

[Dmitry Risenberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100807/
-----------------------------------------------------------

(Updated March 8, 2011, 1:25 p.m.)


Review request for KDevelop.


Changes
-------

Different paths to one document are now treated as the same one, so it will be parsed only one time instead of one for each distinct path to it. Looks like it breaks nothing. No need for QMap/QHash changes in this case.


Summary
-------

When a document was added for parsing with multiple priorities, a default DocumentParsePlan was retrieved from m_documents when creating jobs after the first one. This led to incorrect set of features for parsing job and might trigger unnecessary reparsing when a file was reloaded.

Changed m_documents from QMap to QHash to avoid hitting https://bugs.kde.org/show_bug.cgi?id=267732.


Diffs (updated)
-----

  language/backgroundparser/backgroundparser.h a04949f26f706bcdfc3d0fa26fa7c3c16bf3509d 
  language/backgroundparser/backgroundparser.cpp 540a453e74d4a518e54bc9b5fa0c982d76088ea1 

Diff: http://git.reviewboard.kde.org/r/100807/diff


Testing
-------


Thanks,

Dmitry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110308/c1810032/attachment.html>