<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100807/">http://git.reviewboard.kde.org/r/100807/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100807/diff/2/?file=10769#file10769line160" style="color: black; font-weight: bold; text-decoration: underline;">language/backgroundparser/backgroundparser.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public Q_SLOTS:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">160</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">addDocument</span><span class="p">(</span><span class="k"><span class="hl">const</span></span><span class="hl"> </span><span class="n">KUrl</span><span class="o"><span class="hl">&</span></span> <span class="n">url</span><span class="p">,</span> <span class="n">TopDUContext</span><span class="o">::</span><span class="n">Features</span> <span class="n">features</span> <span class="o">=</span> <span class="n">TopDUContext</span><span class="o">::</span><span class="n">VisibleDeclarationsAndContexts</span><span class="p">,</span> <span class="kt">int</span> <span class="n">priority</span> <span class="o">=</span> <span class="mi">0</span><span class="p">,</span> <span class="n">QObject</span><span class="o">*</span> <span class="n">notifyWhenReady</span> <span class="o">=</span> <span class="mi">0</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">160</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">addDocument</span><span class="p">(</span><span class="n">KUrl</span> <span class="n">url</span><span class="p">,</span> <span class="n">TopDUContext</span><span class="o">::</span><span class="n">Features</span> <span class="n">features</span> <span class="o">=</span> <span class="n">TopDUContext</span><span class="o">::</span><span class="n">VisibleDeclarationsAndContexts</span><span class="p">,</span> <span class="kt">int</span> <span class="n">priority</span> <span class="o">=</span> <span class="mi">0</span><span class="p">,</span> <span class="n">QObject</span><span class="o">*</span> <span class="n">notifyWhenReady</span> <span class="o">=</span> <span class="mi">0</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this breaks the API, preventing this to go into 4.2, rather create a copy of the cleaned url in the implementation and keep the interface intact</pre>
</div>
<br />
<p>- Milian</p>
<br />
<p>On March 8th, 2011, 1:25 p.m., Dmitry Risenberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Dmitry Risenberg.</div>
<p style="color: grey;"><i>Updated March 8, 2011, 1:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When a document was added for parsing with multiple priorities, a default DocumentParsePlan was retrieved from m_documents when creating jobs after the first one. This led to incorrect set of features for parsing job and might trigger unnecessary reparsing when a file was reloaded.
Changed m_documents from QMap to QHash to avoid hitting https://bugs.kde.org/show_bug.cgi?id=267732.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>language/backgroundparser/backgroundparser.h <span style="color: grey">(a04949f26f706bcdfc3d0fa26fa7c3c16bf3509d)</span></li>
<li>language/backgroundparser/backgroundparser.cpp <span style="color: grey">(540a453e74d4a518e54bc9b5fa0c982d76088ea1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100807/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>