Review Request: kdev-custom-buildsystem plugin: When the builddirectory in the configuration is left empty, the builddirectory should point to the project's source dir.

[Morten Volden]

> On Dec. 22, 2011, 3:39 a.m., Andreas Pakulat wrote:
> > Hmm, I'm not sure I like this. IMHO defaulting to in-source builds is bad (well, in-source builds should be banned from this universe actually), it should rather be flagged as an error if there's no builddir and building should be refused.

Banned from the universe may be a bit harsh, but I agree in-source builds should be avoided. :-)

However, the builddir only says something about from where the custom build system should be executed, it does not necessarily say anything about whether or not the buildsystem uses in- or out-of-source build. The build system I am using, for example: It is possible to issue a build command in the root of a package containing multiple projects (each with separate source directory), or in the source directory of a given project.

Fixed whitespace issue, unrelated change, and removed unecessary test files.


- Morten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103499/#review9156
-----------------------------------------------------------


On Dec. 22, 2011, 4:41 p.m., Morten Volden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103499/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2011, 4:41 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> kdev-custom-buildsystem plugin: When the builddirectory in the configuration is left empty, the builddirectory should point to the project's source dir. This patch fixes a bug that made it point to / if the builddirectory key is there but not set.
> 
> 
> Diffs
> -----
> 
>   custombuildsystemplugin.cpp 1bf5b48 
>   tests/custombuildsystemplugintest.h 849d082 
>   tests/custombuildsystemplugintest.cpp 97b3b0c 
>   tests/projects/builddirproject/.kdev4/builddirproject.kdev4 PRE-CREATION 
>   tests/projects/builddirproject/builddirproject.kdev4 PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103499/diff/diff
> 
> 
> Testing
> -------
> 
> Added a unittest to verify
> 
> 
> Thanks,
> 
> Morten Volden
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111222/c661d2cd/attachment.html>