Review Request: kdev-custom-buildsystem plugin: When the builddirectory in the configuration is left empty, the builddirectory should point to the project's source dir.

Morten Volden mvolden2 at gmail.com
Thu Dec 22 16:41:07 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103499/
-----------------------------------------------------------

(Updated Dec. 22, 2011, 4:41 p.m.)


Review request for KDevelop.


Description
-------

kdev-custom-buildsystem plugin: When the builddirectory in the configuration is left empty, the builddirectory should point to the project's source dir. This patch fixes a bug that made it point to / if the builddirectory key is there but not set.


Diffs (updated)
-----

  custombuildsystemplugin.cpp 1bf5b48 
  tests/custombuildsystemplugintest.h 849d082 
  tests/custombuildsystemplugintest.cpp 97b3b0c 
  tests/projects/builddirproject/.kdev4/builddirproject.kdev4 PRE-CREATION 
  tests/projects/builddirproject/builddirproject.kdev4 PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103499/diff/diff


Testing
-------

Added a unittest to verify


Thanks,

Morten Volden

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111222/63b60533/attachment.html>


More information about the KDevelop-devel mailing list