Review Request: kdev-custom-buildsystem plugin: When the builddirectory in the configuration is left empty, the builddirectory should point to the project's source dir.

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103499/#review9156
-----------------------------------------------------------


Hmm, I'm not sure I like this. IMHO defaulting to in-source builds is bad (well, in-source builds should be banned from this universe actually), it should rather be flagged as an error if there's no builddir and building should be refused.


tests/custombuildsystemplugintest.cpp
<http://git.reviewboard.kde.org/r/103499/#comment7584>

    unrelated whitespace change



tests/custombuildsystemplugintest.cpp
<http://git.reviewboard.kde.org/r/103499/#comment7585>

    extra whitespace



tests/custombuildsystemplugintest.cpp
<http://git.reviewboard.kde.org/r/103499/#comment7586>

    this looks like an unrelated change. Either that or it should be mentioned why this was changed


The sample project only needs a .kdev4 file, the rest of the files are not necessary for the test.

- Andreas Pakulat


On Dec. 21, 2011, 9:50 p.m., Morten Volden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103499/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2011, 9:50 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> kdev-custom-buildsystem plugin: When the builddirectory in the configuration is left empty, the builddirectory should point to the project's source dir. This patch fixes a bug that made it point to / if the builddirectory key is there but not set.
> 
> 
> Diffs
> -----
> 
>   custombuildsystemplugin.cpp 1bf5b48 
>   tests/custombuildsystemplugintest.h 849d082 
>   tests/custombuildsystemplugintest.cpp 97b3b0c 
>   tests/projects/builddirproject/.kdev4/builddirproject.kdev4 PRE-CREATION 
>   tests/projects/builddirproject/builddirproject.kdev4 PRE-CREATION 
>   tests/projects/builddirproject/config.h PRE-CREATION 
>   tests/projects/builddirproject/src/main.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103499/diff/diff
> 
> 
> Testing
> -------
> 
> Added a unittest to verify
> 
> 
> Thanks,
> 
> Morten Volden
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111222/f0d285f6/attachment.html>