<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103499/">http://git.reviewboard.kde.org/r/103499/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 22nd, 2011, 3:39 a.m., <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, I'm not sure I like this. IMHO defaulting to in-source builds is bad (well, in-source builds should be banned from this universe actually), it should rather be flagged as an error if there's no builddir and building should be refused.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Banned from the universe may be a bit harsh, but I agree in-source builds should be avoided. :-)
However, the builddir only says something about from where the custom build system should be executed, it does not necessarily say anything about whether or not the buildsystem uses in- or out-of-source build. The build system I am using, for example: It is possible to issue a build command in the root of a package containing multiple projects (each with separate source directory), or in the source directory of a given project.
Fixed whitespace issue, unrelated change, and removed unecessary test files.
</pre>
<br />
<p>- Morten</p>
<br />
<p>On December 22nd, 2011, 4:41 p.m., Morten Volden wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Morten Volden.</div>
<p style="color: grey;"><i>Updated Dec. 22, 2011, 4:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kdev-custom-buildsystem plugin: When the builddirectory in the configuration is left empty, the builddirectory should point to the project's source dir. This patch fixes a bug that made it point to / if the builddirectory key is there but not set.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added a unittest to verify</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>custombuildsystemplugin.cpp <span style="color: grey">(1bf5b48)</span></li>
<li>tests/custombuildsystemplugintest.h <span style="color: grey">(849d082)</span></li>
<li>tests/custombuildsystemplugintest.cpp <span style="color: grey">(97b3b0c)</span></li>
<li>tests/projects/builddirproject/.kdev4/builddirproject.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/projects/builddirproject/builddirproject.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103499/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>