D21247: [pretty please] allow fetching of cover art in mpris plugin from connected computer

[Nicolas Fella]

nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.


  Your problem description is a bit inaccurate. The problem is not a local IP, it's that you don't serve the covers over https. I have a similar problem myself: Spotify is shipping album art over http.
  
  > Obviously I can not have a domain set for my computer on a local machine
  
  That's not true. You could set up your own DNS server that achieves that. But anyhow, not relevant here
  
  @andyholmes It should be able to implement somenthing like that as well, but I don't see how it solves the problem in the bigger picture.
  The problem is that unencrypted network connections have risks security and privacy wise. Those are there regardless of whether the cover is fetched on the desktop or the phone. Assuming that both devices are in a network with NAT I don't think those connections could be distinguished from the outside anyway. Privacy-wise the damage is pretty much already done since I assume that the Spotify (and possibly other clients) already have fetched the cover themselves.
  
  TL;DR
  Patch looks good to me, let's wait a few days if someone objects.
  
  To merge this we need your full name + email address please.

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D21247

To: cotko, #kde_connect, nicolasfella
Cc: nicolasfella, andyholmes, kdeconnect, ewentzel, dshelley, pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20190516/0b2fba2b/attachment.html>