<table><tr><td style="">nicolasfella accepted this revision.<br />nicolasfella added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21247">View Revision</a></tr></table><br /><div><div><p>Your problem description is a bit inaccurate. The problem is not a local IP, it's that you don't serve the covers over https. I have a similar problem myself: Spotify is shipping album art over http.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Obviously I can not have a domain set for my computer on a local machine</p></blockquote>
<p>That's not true. You could set up your own DNS server that achieves that. But anyhow, not relevant here</p>
<p><a href="https://phabricator.kde.org/p/andyholmes/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@andyholmes</a> It should be able to implement somenthing like that as well, but I don't see how it solves the problem in the bigger picture.<br />
The problem is that unencrypted network connections have risks security and privacy wise. Those are there regardless of whether the cover is fetched on the desktop or the phone. Assuming that both devices are in a network with NAT I don't think those connections could be distinguished from the outside anyway. Privacy-wise the damage is pretty much already done since I assume that the Spotify (and possibly other clients) already have fetched the cover themselves.</p>
<p>TL;DR<br />
Patch looks good to me, let's wait a few days if someone objects.</p>
<p>To merge this we need your full name + email address please.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R225 KDE Connect - Android application</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21247">https://phabricator.kde.org/D21247</a></div></div><br /><div><strong>To: </strong>cotko, KDE Connect, nicolasfella<br /><strong>Cc: </strong>nicolasfella, andyholmes, kdeconnect, ewentzel, dshelley, pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, skymoore, brute4s99, wistak, anoopv, dvalencia, rmenezes, julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, lemuel, menasshock, mikesomov, tctara, apol<br /></div>