D13594: [WIP] Split SMS and Telephony plugin on desktop
Nicolas Fella
noreply at phabricator.kde.org
Mon Jun 18 23:17:02 UTC 2018
nicolasfella created this revision.
nicolasfella added a reviewer: KDE Connect.
Restricted Application added a project: KDE Connect.
Restricted Application added a subscriber: kdeconnect.
nicolasfella requested review of this revision.
REVISION SUMMARY
Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that @sredman has big plans with SMS.
This diff should be fully backwards compatible, but whether we really want to do that is up to discussion
TEST PLAN
Only supeficially tested. Receive an SMS (old way), Notification is shown
REPOSITORY
R224 KDE Connect
BRANCH
smsrefactor
REVISION DETAIL
https://phabricator.kde.org/D13594
AFFECTED FILES
interfaces/CMakeLists.txt
interfaces/dbusinterfaces.cpp
interfaces/dbusinterfaces.h
plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp
plugins/CMakeLists.txt
plugins/sms/CMakeLists.txt
plugins/sms/conversationsdbusinterface.cpp
plugins/sms/conversationsdbusinterface.h
plugins/sms/kdeconnect_sms.json
plugins/sms/smsplugin.cpp
plugins/sms/smsplugin.h
plugins/telephony/CMakeLists.txt
plugins/telephony/conversationsdbusinterface.cpp
plugins/telephony/conversationsdbusinterface.h
plugins/telephony/kdeconnect_telephony.json
plugins/telephony/telephonyplugin.cpp
plugins/telephony/telephonyplugin.h
To: nicolasfella, #kde_connect
Cc: sredman, kdeconnect, #kde_connect, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180618/9c019939/attachment.html>
More information about the KDEConnect
mailing list