<table><tr><td style="">nicolasfella created this revision.<br />nicolasfella added a reviewer: KDE Connect.<br />Restricted Application added a project: KDE Connect.<br />Restricted Application added a subscriber: kdeconnect.<br />nicolasfella requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13594">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that <a href="https://phabricator.kde.org/p/sredman/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@sredman</a> has big plans with SMS.<br />
This diff should be fully backwards compatible, but whether we really want to do that is up to discussion</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Only supeficially tested. Receive an SMS (old way), Notification is shown</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R224 KDE Connect</div></div></div><br /><div><strong>BRANCH</strong><div><div>smsrefactor</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13594">https://phabricator.kde.org/D13594</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>interfaces/CMakeLists.txt<br />
interfaces/dbusinterfaces.cpp<br />
interfaces/dbusinterfaces.h<br />
plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp<br />
plugins/CMakeLists.txt<br />
plugins/sms/CMakeLists.txt<br />
plugins/sms/conversationsdbusinterface.cpp<br />
plugins/sms/conversationsdbusinterface.h<br />
plugins/sms/kdeconnect_sms.json<br />
plugins/sms/smsplugin.cpp<br />
plugins/sms/smsplugin.h<br />
plugins/telephony/CMakeLists.txt<br />
plugins/telephony/conversationsdbusinterface.cpp<br />
plugins/telephony/conversationsdbusinterface.h<br />
plugins/telephony/kdeconnect_telephony.json<br />
plugins/telephony/telephonyplugin.cpp<br />
plugins/telephony/telephonyplugin.h</div></div></div><br /><div><strong>To: </strong>nicolasfella, KDE Connect<br /><strong>Cc: </strong>sredman, kdeconnect, KDE Connect, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol<br /></div>