D12878: A little hack to unlock device from android using fingerprint authentication from QS tile

[Nicolas Fella]

nicolasfella added a comment.


  There already is a unlock plugin that you can use as desktop counterpart in the desktop repo. https://cgit.kde.org/kdeconnect-kde.git/tree/plugins/lockdevice To build it you must pass -DEXPERIMENTALAPP_ENABLED with the cmake command.

INLINE COMMENTS

> LockPlugin.java:38
> +
> +    /* Should it be available via UI?
> +    @Override

I would say yes

> LockTileService.java:77
> +
> +    private boolean unlockComputer() {
> +        BackgroundService.RunCommand(this, service -> {

Why two different unlockComputer()?

> LockTileService.java:98
> +
> +    private boolean unlockComputer(int a) {
> +        BackgroundService.RunCommand(this, service -> {

What does a do?

> LockTileService.java:101
> +            //TODO: don't piggyback on runcommand
> +            String deviceId = getSharedPreferences(STATE_SELECTED_DEVICE,
> +                    Context.MODE_PRIVATE)

Where is the preference written?

REPOSITORY
  R225 KDE Connect - Android application

REVISION DETAIL
  https://phabricator.kde.org/D12878

To: bhav97, #kde_connect
Cc: nicolasfella, kdeconnect, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, ach, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20180616/ba6c9d1b/attachment.html>